Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The socket.entity_id field was removed in 7.4.0 #32316

Merged
merged 2 commits into from
Jul 18, 2022
Merged

The socket.entity_id field was removed in 7.4.0 #32316

merged 2 commits into from
Jul 18, 2022

Conversation

dharada
Copy link
Contributor

@dharada dharada commented Jul 11, 2022

see - #17346

What does this PR do?

to fix a docs bug.

Why is it important?

it cause to misunderstand about auditbeat spec.

@dharada dharada requested a review from a team as a code owner July 11, 2022 23:47
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 11, 2022
@dharada dharada added the Team:Docs Label for the Observability docs team label Jul 11, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-docs (Team:Docs)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 11, 2022
@dharada dharada added Auditbeat needs_team Indicates that the issue/PR needs a Team:* label labels Jul 11, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 11, 2022
@botelastic
Copy link

botelastic bot commented Jul 11, 2022

This pull request doesn't have a Team:<team> label.

@dharada dharada removed their assignment Jul 11, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 11, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-13T19:06:55.653+0000

  • Duration: 50 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 544
Skipped 81
Total 625

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6
Copy link
Contributor

efd6 commented Jul 12, 2022

This change needs to happen in auditbeat/module/system/_meta/fields.yml and then be generated into the asciidoc.

@dharada
Copy link
Contributor Author

dharada commented Jul 12, 2022 •
edited
Loading

This change needs to happen in auditbeat/module/system/_meta/fields.yml and then be generated into the asciidoc.

@efd6 thanks for checking.

@elastic/docs could you take care of this ? thanks in advance.

p.s - I have no idea why I got assinged to this PR. (mergify bot still keep assign me ..)

@dharada dharada removed their assignment Jul 12, 2022
@dedemorton
Copy link
Contributor

@dharada I'll take care of it!

@dedemorton dedemorton assigned dedemorton and unassigned dharada Jul 13, 2022
@dedemorton dedemorton added backport-v8.3.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.2.0 Automated backport with mergify labels Jul 13, 2022
@dedemorton
Copy link
Contributor

I'm being optimistic with backport labels. I'll backport this as far as I can, but it can be tricky sometimes to get CI to pass on backports to old branches.

@dedemorton
Copy link
Contributor

@efd6 Can you take another look and approve if it looks good to you? Thanks!

efd6
efd6 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@dedemorton dedemorton merged commit ccee622 into main Jul 18, 2022
@dedemorton dedemorton deleted the dharada-patch-1-socket.entity_id-field-was-removed branch July 18, 2022 19:42
mergify bot pushed a commit that referenced this pull request Jul 18, 2022
@dharada @mergify
The socket.entity_id field was removed in 7.4.0 (#32316)
3329623 
* The socket.entity_id field was removed in 7.4.0

see - #17346

* Remove socket.entity_id field from fields.yml

Co-authored-by: dedemorton <dede.morton@elastic.co>
(cherry picked from commit ccee622)
@mergify mergify bot mentioned this pull request Jul 18, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 18, 2022
@dharada @mergify
The socket.entity_id field was removed in 7.4.0 (#32316)
1d8777a 
* The socket.entity_id field was removed in 7.4.0

see - #17346

* Remove socket.entity_id field from fields.yml

Co-authored-by: dedemorton <dede.morton@elastic.co>
(cherry picked from commit ccee622)
@mergify mergify bot mentioned this pull request Jul 18, 2022
Closed
mergify bot pushed a commit that referenced this pull request Jul 18, 2022
@dharada @mergify
The socket.entity_id field was removed in 7.4.0 (#32316)
fe56433 
* The socket.entity_id field was removed in 7.4.0

see - #17346

* Remove socket.entity_id field from fields.yml

Co-authored-by: dedemorton <dede.morton@elastic.co>
(cherry picked from commit ccee622)
@mergify mergify bot mentioned this pull request Jul 18, 2022
Merged
dedemorton pushed a commit that referenced this pull request Jul 18, 2022
@mergify @dharada
The socket.entity_id field was removed in 7.4.0 (#32316) (#32389)
40d35c0 
* The socket.entity_id field was removed in 7.4.0

see - #17346

* Remove socket.entity_id field from fields.yml

Co-authored-by: dedemorton <dede.morton@elastic.co>
(cherry picked from commit ccee622)

Co-authored-by: Daisuke Harada <1519063+dharada@users.noreply.github.com>
dedemorton pushed a commit that referenced this pull request Jul 18, 2022
@mergify @dharada
The socket.entity_id field was removed in 7.4.0 (#32316) (#32391)
c5b0c63 
* The socket.entity_id field was removed in 7.4.0

see - #17346

* Remove socket.entity_id field from fields.yml

Co-authored-by: dedemorton <dede.morton@elastic.co>
(cherry picked from commit ccee622)

Co-authored-by: Daisuke Harada <1519063+dharada@users.noreply.github.com>
@dedemorton dedemorton removed the backport-v8.2.0 Automated backport with mergify label Jul 20, 2022
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@mergify @dharada
The socket.entity_id field was removed in 7.4.0 (elastic#32316) (ela…
7c5c3a7 
…stic#32391)

* The socket.entity_id field was removed in 7.4.0

see - elastic#17346

* Remove socket.entity_id field from fields.yml

Co-authored-by: dedemorton <dede.morton@elastic.co>
(cherry picked from commit ccee622)

Co-authored-by: Daisuke Harada <1519063+dharada@users.noreply.github.com>
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@dharada @dedemorton @chrisberkhout
The socket.entity_id field was removed in 7.4.0 (#32316)
4784501 
* The socket.entity_id field was removed in 7.4.0

see - #17346

* Remove socket.entity_id field from fields.yml

Co-authored-by: dedemorton <dede.morton@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@dedemorton dedemorton

Labels
Auditbeat backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify backport-v8.1.0 Automated backport with mergify backport-v8.3.0 Automated backport with mergify Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dharada @elasticmachine @efd6 @dedemorton