Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS] Fix CloudWatch readCloudwatchConfig function #32408

Merged
merged 3 commits into from
Jul 20, 2022
Merged

[AWS] Fix CloudWatch readCloudwatchConfig function #32408

merged 3 commits into from
Jul 20, 2022

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jul 19, 2022 •
edited
Loading

What does this PR do?

Fix AWS cloudwatch metricset readCloudwatchConfig function to construct resource types with tags.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner July 19, 2022 20:35
@kaiyan-sheng kaiyan-sheng self-assigned this Jul 19, 2022
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Jul 19, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 19, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-07-19T22:19:24.726+0000

  • Duration: 85 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 1109
Skipped 107
Total 1216

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

tommyers-elastic
tommyers-elastic approved these changes Jul 20, 2022
View reviewed changes
Copy link
Contributor

@tommyers-elastic tommyers-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks !

@tommyers-elastic tommyers-elastic merged commit 50f968d into elastic:main Jul 20, 2022
@kaiyan-sheng kaiyan-sheng added backport-v8.3.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify labels Jul 20, 2022
@kaiyan-sheng kaiyan-sheng deleted the readCloudwatchConfig branch July 20, 2022 15:05
mergify bot pushed a commit that referenced this pull request Jul 20, 2022
@kaiyan-sheng @mergify
[AWS] Fix CloudWatch readCloudwatchConfig function (#32408)
5b9e474 
* Fix AWS CloudWatch readCloudwatchConfig function

* address golangci-lint error

* fix more lint error

(cherry picked from commit 50f968d)

# Conflicts:
#	x-pack/metricbeat/module/aws/cloudwatch/cloudwatch.go
@mergify mergify bot mentioned this pull request Jul 20, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jul 20, 2022
@kaiyan-sheng @mergify
[AWS] Fix CloudWatch readCloudwatchConfig function (#32408)
feeba57 
* Fix AWS CloudWatch readCloudwatchConfig function

* address golangci-lint error

* fix more lint error

(cherry picked from commit 50f968d)
@mergify mergify bot mentioned this pull request Jul 20, 2022
Merged
This was referenced Jul 20, 2022
Merged
Merged
kaiyan-sheng added a commit that referenced this pull request Jul 22, 2022
@mergify @kaiyan-sheng
[8.3](backport #32408) [AWS] Fix CloudWatch readCloudwatchConfig func…
1755b5d 
…tion (#32418)

(cherry picked from commit 50f968d)

* fix return error for reportEvents

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng pushed a commit that referenced this pull request Jul 25, 2022
@mergify
[7.17](backport #32408) [AWS] Fix CloudWatch readCloudwatchConfig fun…
de9b2b8 
…ction (#32417)

(cherry picked from commit 50f968d)
@tommyers-elastic tommyers-elastic mentioned this pull request Aug 4, 2022
Closed
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
@kaiyan-sheng @chrisberkhout
[AWS] Fix CloudWatch readCloudwatchConfig function (#32408)
dfd9f9f 
* Fix AWS CloudWatch readCloudwatchConfig function

* address golangci-lint error

* fix more lint error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tommyers-elastic tommyers-elastic tommyers-elastic approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.3.0 Automated backport with mergify Team:Cloud-Monitoring Label for the Cloud Monitoring team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaiyan-sheng @elasticmachine @tommyers-elastic