-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.17](backport #32360) system.auth - sync pipeline with Fleet integration #32422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync the pipeline for the system.auth dataset with the Fleet integration from elastic/integrations#3705. This removes the event.type authentication_failed and authentication_success values which are not allowed as per ECS. You can use event.category: authentication and event.outcome: success/failure to query instead. (cherry picked from commit 475dd7e)
mergify
bot
requested review from
cmacknz and
fearful-symmetry
and removed request for
a team
July 20, 2022 16:43
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 20, 2022
This pull request doesn't have a |
Collaborator
The module tests were failing because the empty tags array was being discarded resulting in the tags value being treated as `nil`. And this was not being accepted as a valid type for the inList function. The cause was elastic/go-ucfg#188.
This pull request has not been merged yet. Could you please review and merge it @andrewkroh? 🙏 |
Backport fix from 0022ea4.
andrewkroh
force-pushed
the
mergify/bp/7.17/pr-32360
branch
from
July 25, 2022 14:48
c375e0c
to
925613a
Compare
/test |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #32360 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com