-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsonhelper #3280
Add jsonhelper #3280
Conversation
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
@ruflin, @andrewkroh Is there something more to do after creating a new package?? |
Why i had to create a directory which has the same name like the go file to get this working?? |
After chatting with @tsg, we decided to put helper into |
@maddin2016 Can you please add Otherwise LGTM. |
Hi @andrewkroh, what |
It's a conditional statement like:
|
Ok, i asked because i don't find it at source code. |
This needs to be back ported to 5.2 to get the bug fix for the missing |
WriteJSONKeys reduces code duplication between the Filebeat json parser and the decode_json_fields processor. Fixed bug with decode_json_fields where the `when` condition was not allowed.
Helper lib to write json keys for an event. Also refactored #3169