-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat][httpjson] - Separation of global transform contexts and introduction of parent transform context within chains #33499
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request is now in conflicts. Could you fix it? 🙏
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, otherwise LGTM.
@efd6 have made the necessary improvements with updated docs and test cases. Now dot's in expressions and hard coded values will be properly processed. |
@efd6 updated the docs and the processExpression method. In the end decided to keep the default behaviour as it made more sense. The docs have been updated accordingly and test cases have been add to support the same. |
@efd6 updated PR with the processException tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
…troduction of parent transform context within chains (#33499) * initial commit for transform context separation and introduction of parent object * removed ioutil from tests * updated asciidoc changelog * added support for dot's in values and expressions for replace_with clause, added doc updates and tests * added linter ignores for errcheck in test scenario * updated as per pr suggetions * added processExpression Tests
Type of change
What does this PR do?
This PR introduces the following enhancements to httpjson -
object) which is a self referential pointer and this will point to the transform context of the root request when accessed
from within chain steps.
during chaining.
Why is it important?
of their respective transform contexts, hence reducing the chances of unexpected errors due to overlapping transform
contexts.
cases to be implemented. For example a request with chaining, where the root request on every page response
receives an unique id in the body, which is then passed to the respective chain requests to extract the required
information. The test included simulates this scenario.
Checklist
-
[ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
.Author's Checklist
Related issues