Add HTTP helper for Metricsets #3413
Conversation
| client *http.Client // HTTP client that is reused across requests. | ||
| } | ||
|
|
||
| // NewHttpMetricset creates new instance of HttpMetriSset |
There was a problem hiding this comment.
Looks more like the comment is out of date, it should be "creates a new instance of Http". Btw, HTTP is an acronym so usually it shows up as HTTP in Go code, right? That might look weird though.
There was a problem hiding this comment.
Yeah, in the first version it was call HttpMetricset because it was not in the metricset package.
You are right based on our standard it should be called HTTP, but it will look wiered :-( I would prefer to leave it. @urso Thoughts.
ruflin
force-pushed
the
http-helper
branch
2 times, most recently
from
6daf205 to
0ca6c80
Compare
| "github.com/elastic/beats/metricbeat/mb" | ||
| ) | ||
|
|
||
| type Http struct { |
There was a problem hiding this comment.
:-) @tsg and me had the same discussion, but came to the conclusion HTTP will look ugly :-) What would you call the private variable in this case? http?
There was a problem hiding this comment.
There was a problem hiding this comment.
I don't see anything wrong with http *helper.HTTP. It's not much different from http *helper.Http. Or am I missing something?
This should simplify the implementation of MetricSets based on HTTP.
This should simplify the implementation of MetricSets based on HTTP.