-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate Source IP "LOCAL" or "Unknown" in Windows Security Logs #34252
Conversation
💚 CLA has been signed |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
❕ Build Aborted
Expand to view the summary
Build stats
Steps errorsExpand to view the steps failures
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Can we backport this as a bug fix? |
@MakoWish Please sign the CLA so that we can take a look at this. |
Your GitHub handle is recognised as having signed the CLA but this PR does not appear to be signed. Would you please check that the email address in the commits that you authored matches the email address that you used when you signed the CLA; there are two identities in these commits and I suspect that the second may not be a CLA-known identity. |
I signed the CLA with my personal email, but I would prefer not to use that on commits. The commits should be configured with the GH "no reply" account. Is there a way to add th "no reply" account "26614684+MakoWish@users.noreply.github.com" to the CLA? |
Can you try resigning with that email address? |
This pull request is now in conflicts. Could you fix it? 🙏
|
Having a hard time changing this one. Have any tips on how to do that? |
Thanks for fixing the CLA signing. This has brought in many changes that are unrelated to the fix here; are you able to reduce it down to just the changes that you are needing to make please. |
Wasn't sure how to remove the changes I inadvertently added, and accidentally removed everything. I will open a new PR with just the changes for the source IP issue. |
What does this PR do?
Some security events contain a source IP address of "LOCAL" or "Unknown" which are not valid IP addresses. This PR will correct the processing of events containing one of those values.
Why is it important?
This bug causes mapping exceptions and prevents these events from being ingested.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Related issues
-fixes #19627