Metricbeat : new metricset image for docker module #3467
Conversation
|
Hi @douaejeouit, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
|
@karmi it's done! |
|
@ruflin your review is welcome! |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
|
@douaejeouit thanks!, but it keeps failing, have you added your Gmail to the Github profile? That should normally suffice to make that green, even when the commit has a different e-mail. |
|
@karmi that's weird 😢 I added both of my e-mails .. |
|
Hi @douaejeouit, I've reached out via e-mail, ping me if you need assistance! |
There was a problem hiding this comment.
Some notes
- It seems the local
fields.ymlfor the metricset is missing - Could you generate the
data.json? - Can you add a docs check test to
test_docker.py? - Update to CHANGELOG.asciidoc
This should also make the build green. Don't forget to run make update and make fmt.
update templates add data.json add docs check to test_docker.py update CHANGELOG.asciidoc make update - make fmt - make collect
douaejeouit
force-pushed
the
metricset-image
branch
from
4243d28 to
174aa0d
Compare
| output = self.read_output_json() | ||
| evt = output[0] | ||
|
|
||
| evt = self.remove_labels(evt) |
There was a problem hiding this comment.
As the image data set probably doesn't have fields, this line is not needed
| }, | ||
| "repoTags": image.RepoTags, | ||
| } | ||
| labels := docker.DeDotLabels(image.Labels) |
There was a problem hiding this comment.
Oh, I see it has labels. Ignore my comment below. But it seems the line with the labels somehow breaks the tests. See Travis.
There was a problem hiding this comment.
Yes, I'll check it!
| - name: example | ||
| type: keyword | ||
| description: > | ||
| Example field |
There was a problem hiding this comment.
This must be completed with the fields, otherwise the system test will not pass.
There was a problem hiding this comment.
Ok, I'll complete it!
…ed in fields.yml. TODO : How to document list ?
|
@ruflin Have you thought about the way we should document lists? |
|
@douaejeouit Which lists are you referring to? labels? My solution currently is to not document it (which is not great). Perhaps we could at least define an empty object: https://www.elastic.co/guide/en/elasticsearch/reference/current/object.html |
|
@douaejeouit I found that we use |
|
@ruflin , yes I am referring to labels as well as tags. |
|
See #3515 |
| @@ -0,0 +1,19 @@ | |||
| { | |||
There was a problem hiding this comment.
Needs update but I can do that after merging.
|
@douaejeouit Thanks for the contribution. |
|
With the greatest of pleasure @ruflin |
Basic informations about the images available on the server