Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filebeat/module/nginx/ingress_controller: Add unix socket log parsing #34732

Merged
merged 5 commits into from
Mar 8, 2023

Conversation

leweafan
Copy link
Contributor

@leweafan leweafan commented Mar 4, 2023

What does this PR do?

Adds unix socket log parsing for nginx ingress_controller

Why is it important?

Nginx ingress_controller pipeline can not parse kubernetes nginx ingress controller logs if unix socket used.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@leweafan leweafan requested a review from a team as a code owner March 4, 2023 14:37
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leweafan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-08T07:13:11.589+0000

  • Duration: 71 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 7567
Skipped 746
Total 8313

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@leweafan leweafan changed the title Add unix socket log parsing for nginx ingress_controller filebeat/module/nginx/ingress_controller: Add unix socket log parsing Mar 6, 2023
@tetianakravchenko tetianakravchenko added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Mar 6, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 6, 2023
@tetianakravchenko tetianakravchenko requested review from a team, gizas and tetianakravchenko and removed request for a team March 6, 2023 11:18
Copy link
Contributor

@tetianakravchenko tetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
@tetianakravchenko
Copy link
Contributor

@gsantoro could you please review as well? do you think it is smth that we should backport to https://github.com/elastic/integrations/tree/main/packages/nginx_ingress_controller?

leweafan and others added 2 commits March 6, 2023 21:29
Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b main upstream/main
git merge upstream/main
git push upstream main

@tetianakravchenko tetianakravchenko merged commit 88b1cac into elastic:main Mar 8, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
…#34732)

* Add unix socket log parsing for nginx ingress_controller

* Update CHANGELOG.next.asciidoc - added pull request id

Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>

---------

Co-authored-by: Tetiana Kravchenko <tanya.kravchenko.v@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nginx ingress_controller pipeline can not parse domain socket
4 participants