Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky test (x-pack.metricbeat.module.sql.query.test_sql_oracle.Test) #35083

Merged
merged 2 commits into from
Apr 13, 2023

Conversation

faec
Copy link
Contributor

@faec faec commented Apr 13, 2023

x-pack.metricbeat.module.sql.query.test_sql_oracle.Test is broken (#34993) and a PR was submitted to disable it last week (#35030) however it's still running and failing on active PRs, presumably because the @unittest.skip directives didn't stack correctly in the unittest api. This PR removes the conflicting directive so the test will be skipped for real.

@faec faec added bug Team:Elastic-Agent Label for the Agent team labels Apr 13, 2023
@faec faec requested a review from a team as a code owner April 13, 2023 20:19
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 13, 2023
@mergify mergify bot assigned faec Apr 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Apr 13, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @faec? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T20:28:09.313+0000

  • Duration: 53 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 1409
Skipped 95
Total 1504

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@faec faec added the backport-v8.7.0 Automated backport with mergify label Apr 13, 2023
@faec faec merged commit f245b44 into elastic:main Apr 13, 2023
mergify bot pushed a commit that referenced this pull request Apr 13, 2023
…e.Test) (#35083)

(cherry picked from commit f245b44)

# Conflicts:
#	x-pack/metricbeat/module/sql/query/test_sql_oracle.py
@faec faec deleted the flaky-test branch April 17, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.7.0 Automated backport with mergify bug Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants