Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable cgroup metric collection by default #3519

Merged
merged 2 commits into from
Feb 5, 2017

Conversation

andrewkroh
Copy link
Member

On Linux cgroup metric collection will be enabled by default. The feature is no longer labeled as experimental. The configuration option has been renamed from cgroups to process.cgroups.enabled.

On Linux cgroup metric collection will be enabled by default. The feature is no longer labeled as experimental. The configuration option has been renamed from `cgroups` to `process.cgroups.enabled`.
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Seems this also needs an update to the system tests.

# EXPERIMENTAL: cgroups can be enabled for the process metricset.
#cgroups: false
# Enable collection of cgroup metrics from processes on Linux.
#process.cgroups.enabled: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add it to the short config as well as it is now a "default" feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather leave it out of the short config. I'd actually be in favor of removing more stuff from the short config. I feel like there's a lot of "noise" in the files and we could have short comment at the top about "see xbeat.full.yml for a commented example with all options" and then remove everything that not necessary. I like the readability of something like this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewkroh Sounds like something we should discuss in general as it would also apply to all other beats. I kind of like the docs as it helps new users (I hope) but it is much more noisy, agree.

@ruflin ruflin merged commit b8beed1 into elastic:master Feb 5, 2017
@tsg tsg mentioned this pull request Feb 6, 2017
13 tasks
@andrewkroh andrewkroh deleted the feature/cgroups-ga branch March 31, 2017 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants