-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Packetbeat] Fix BPF filter setting not being applied to sniffers #35484
Merged
taylor-swanson
merged 2 commits into
elastic:main
from
taylor-swanson:bug/packetbeat-bpf-filter
May 17, 2023
Merged
[Packetbeat] Fix BPF filter setting not being applied to sniffers #35484
taylor-swanson
merged 2 commits into
elastic:main
from
taylor-swanson:bug/packetbeat-bpf-filter
May 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
May 16, 2023
taylor-swanson
force-pushed
the
bug/packetbeat-bpf-filter
branch
from
May 16, 2023 15:03
4d7c95c
to
27c6eba
Compare
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
- Ensure that the BPF filter setting is applied to sniffers
taylor-swanson
force-pushed
the
bug/packetbeat-bpf-filter
branch
from
May 16, 2023 15:04
27c6eba
to
47bb850
Compare
taylor-swanson
added
backport-v8.6.0
Automated backport with mergify
backport-v8.7.0
Automated backport with mergify
backport-v8.8.0
Automated backport with mergify
and removed
backport-v8.6.0
Automated backport with mergify
labels
May 16, 2023
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Collaborator
efd6
approved these changes
May 16, 2023
taylor-swanson
added a commit
that referenced
this pull request
May 17, 2023
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
…5484) - Ensure that the BPF filter setting is applied to sniffers
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-v8.7.0
Automated backport with mergify
backport-v8.8.0
Automated backport with mergify
bug
Packetbeat
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why is it important?
BPF filters were not being applied to pcap and af_packet sniffers and were processing packets that were supposed to be filtered out.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
pcap
oraf_packet
(Linux only) type and configure a BPF filter. Turning on debug logging will either show packets being handled or the sniffer timing out. If you configured the BPF filter to handle traffic known to not exist, then you should see the sniffer time out. If the BPF filter had not applied properly, then it would be picking other traffic (this is especially the case if you connect to the test host using SSH).Related issues