Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct Libbeat docs directory layout #3581

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Correct Libbeat docs directory layout #3581

merged 1 commit into from
Feb 13, 2017

Conversation

strootman
Copy link

The /bin was missing from the docs.

@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@strootman
Copy link
Author

Holy moly!
I think this is the fastest one of my PRs has been approved!

Thanks @andrewkroh ;)

@andrewkroh andrewkroh merged commit befd538 into elastic:5.x Feb 13, 2017
@andrewkroh
Copy link
Member

Thanks for the PR @strootman.

@strootman strootman deleted the Libbeat-Docs-Directory-Layout branch February 14, 2017 00:11
@tsg
Copy link
Contributor

tsg commented Feb 14, 2017

Sorry I missed this one. I'm afraid it's not entirely correct. The /bin/ part was indeed missing for deb and rpm, but the zip/tar.gz have the binary top-level, so there's no /bin/ part.

@dedemorton
Copy link
Contributor

dedemorton commented Jul 7, 2017

I'm adding the needs_backport label to this PR, but it needs a forward port to master because the change was made in all branches but master.

Note that I'll also fix the issue where /bin was incorrectly added to the paths for zip/tar.gz.

@dedemorton dedemorton added the needs_backport PR is waiting to be backported to other branches. label Jul 7, 2017
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jul 7, 2017
dedemorton pushed a commit to dedemorton/beats that referenced this pull request Jul 7, 2017
@dedemorton dedemorton removed the needs_backport PR is waiting to be backported to other branches. label Jul 7, 2017
andrewkroh pushed a commit that referenced this pull request Jul 11, 2017
andrewkroh pushed a commit that referenced this pull request Jul 11, 2017
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants