-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support build of projects outside of beats directory #36126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeniawhite
added
enhancement
backport-skip
Skip notification from the automated backport with mergify
labels
Jul 20, 2023
botelastic
bot
added
the
needs_team
Indicates that the issue/PR needs a Team:* label
label
Jul 20, 2023
This pull request doesn't have a |
Collaborator
jlind23
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
michalpristas
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested this, from my point of view it looks ok
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
* Add project dir * Remove comments * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-skip
Skip notification from the automated backport with mergify
enhancement
needs_team
Indicates that the issue/PR needs a Team:* label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There are
beats
that aren't part of thebeats
repository code-base.Cloudbeat
for example:When calling the
mage package
that is based on thebeats
mage
flows we are getting a failure:I've investigated the code and saw that the
safe.directory
only triggers forbeats
directory:I've added the
root
path of the project as well.Why is it important?
In order to support the building and packaging of
beats
that aren't part of thebeats
repository.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.