[7.17](backport #36256) Filter out duplicate paths resolved from matching globs #36264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Filter out duplicate paths resolved from matching globs Multiple globs can resolve in duplicate filenames. These duplicates must be filtered out even before they reach the creation of file descriptors and additional checks, otherwise this causes a flood of warning messages in logs. These warnings should catch only the cases when symlinks are resolved in known filenames. (cherry picked from commit 4d0276a)
mergify
bot
requested review from
belimawr and
rdner
and removed request for
a team
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
rdner
added a commit
to rdner/beats
that referenced
this pull request
Aug 12, 2023
In elastic#36065 a few fields were renamed in order to clarify their purpose. Unfortunately, this rename was a part of a new feature PR which was not supposed to be backported to 7.17. However, backporting some other changes related to this code has now become challenging and results in build failures (note the fixing commits): - elastic#36095 - elastic#36264 This PR makes the naming consistent with the main branch, so we can easily backport changes.
rdner
added a commit
that referenced
this pull request
Aug 12, 2023
In #36065 a few fields were renamed in order to clarify their purpose. Unfortunately, this rename was a part of a new feature PR which was not supposed to be backported to 7.17. However, backporting some other changes related to this code has now become challenging and results in build failures (note the fixing commits): - #36095 - #36264 This PR makes the naming consistent with the main branch, so we can easily backport changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #36256 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com