-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metricbeat][Kubernetes] Add metricset for state_namespace #36406
Changes from 18 commits
23321a9
443805c
7c85573
e8adb2b
b846be7
5fe0b2f
9ca7330
dc5add7
5e3edf5
2fadbd0
f5d758b
57242e9
eb4a063
039f002
1c19a3d
b120c82
cf927b4
511913c
add12fe
5221f0b
e559998
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,19 +27,7 @@ data: | |
period: 10s | ||
add_metadata: true | ||
metricsets: | ||
- state_node | ||
- state_deployment | ||
- state_daemonset | ||
- state_replicaset | ||
- state_pod | ||
- state_container | ||
- state_cronjob | ||
- state_resourcequota | ||
- state_statefulset | ||
- state_service | ||
- state_persistentvolume | ||
- state_persistentvolumeclaim | ||
- state_storageclass | ||
- state_namespace | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. seems you pushed local changes for this file, could you please revert? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes. Is it ok now with just |
||
- module: kubernetes | ||
metricsets: | ||
- apiserver | ||
|
@@ -64,9 +52,11 @@ data: | |
cloud.auth: ${ELASTIC_CLOUD_AUTH} | ||
|
||
output.elasticsearch: | ||
hosts: ['${ELASTICSEARCH_HOST:elasticsearch}:${ELASTICSEARCH_PORT:9200}'] | ||
hosts: ["https://elasticsearch:9200"] #['${ELASTICSEARCH_HOST:elasticsearch}:${ELASTICSEARCH_PORT:9200}'] | ||
username: ${ELASTICSEARCH_USERNAME} | ||
password: ${ELASTICSEARCH_PASSWORD} | ||
ssl.verification_mode: "none" | ||
allow_older_versions: true | ||
--- | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
|
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"@timestamp": "2019-03-01T08:05:34.853Z", | ||
"event": { | ||
"dataset": "kubernetes.namespace_state", | ||
"duration": 115000, | ||
"module": "kubernetes" | ||
}, | ||
"kubernetes": { | ||
"namespace": "kube-node-lease", | ||
"namespace_state": { | ||
"created": { | ||
"sec": 1691566337 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
} | ||
}, | ||
"metricset": { | ||
"name": "state_namespace", | ||
"period": 10000 | ||
}, | ||
"service": { | ||
"address": "127.0.0.1:55555", | ||
"type": "kubernetes" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
- name: namespace_state | ||
type: group | ||
release: ga | ||
description: > | ||
Kubernetes namespace metrics. | ||
fields: | ||
- name: created.sec | ||
type: double | ||
description: > | ||
Unix creation timestamp. | ||
- name: status | ||
type: group | ||
fields: | ||
- name: active | ||
type: boolean | ||
description: Whether the namespace is active (true or false). | ||
- name: terminating | ||
type: boolean | ||
description: Whether the namespace is terminating (true or false). |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,127 @@ | ||
[ | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "kube-node-lease" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879559 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.namespace_state", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
}, | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "default" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879561 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.namespace_state", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
}, | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "local-path-storage" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879567 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.namespace_state", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
}, | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "kube-public" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879559 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.namespace_state", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
}, | ||
{ | ||
"RootFields": null, | ||
"ModuleFields": { | ||
"namespace": "kube-system" | ||
}, | ||
"MetricSetFields": { | ||
"created": { | ||
"sec": 1673879559 | ||
}, | ||
"status": { | ||
"active": true, | ||
"terminating": false | ||
} | ||
}, | ||
"Index": "", | ||
"ID": "", | ||
"Namespace": "kubernetes.namespace_state", | ||
"Timestamp": "0001-01-01T00:00:00Z", | ||
"Error": null, | ||
"Host": "", | ||
"Service": "", | ||
"Took": 0, | ||
"Period": 0, | ||
"DisableTimeSeries": false | ||
} | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the resource name should be
namespace
so as to be used inevent.dataset
properly. Potentially we could extend the metricset to also add other fields likenamespace_foo
so just usingnamespace_state
for the dataset I think is not so correct.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am afraid that will break again because
kubernetes.state
already exists 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean that the value of
event.dataset
should be set tonamespace
. I think this would work since it's the value that we set so I don't see how it would be in conflict with anything else, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would create a conflict, because that field is setting the object
kubernetes.namespace_state
. And if we change it tokubernetes.namespace
, this is the document that is generated (I just ran this):Which will cause the conflict with the string field
kubernetes.namespace
@ChrsMarkThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to change the
kubernetes.namespace_state
part. This can be as is.I only suggest to change the value of
event.dataset
. I guess it's doable to just set this specifically within the code.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could try that, but how do I set that field? I had a look at the code and:
between these lines, there is still not
event.dataset
field.The
event
is{"_module":{"namespace":"kube-node-lease"},"created":{"sec":1693554126},"status":{"active":true,"terminating":false}}
(example) ande
is{{} {"namespace":"kube-node-lease"} {"created":{"sec":1693554126},"status":{"active":true,"terminating":false}} kubernetes.namespace_state 0001-01-01 00:00:00 +0000 UTC <nil> 0s 0s false}
(example).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that we have change our minds here so many times, just changing event.dataset = kubernetes.namespace_state, breaks also the user experience that metrics that come from kube state metrics have the pattern:
kubernetes.state_*
Just retested those and wanted to bring this to discussion once more. @elastic/obs-cloudnative-monitoring team any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it's best to have this discussion over a meeting? Otherwise it seems it will take some time until we all align. @gizas @ChrsMark