-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat][Crowdstrike] Adding fix to ingest pipeline for command line array handling #36496
Merged
P1llus
merged 5 commits into
elastic:main
from
P1llus:filebeat_module_crowdstrike_arrayspipeline
Sep 5, 2023
Merged
[Filebeat][Crowdstrike] Adding fix to ingest pipeline for command line array handling #36496
P1llus
merged 5 commits into
elastic:main
from
P1llus:filebeat_module_crowdstrike_arrayspipeline
Sep 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e args array handling
P1llus
added
Team:Security-External Integrations
backport-7.17
Automated backport to the 7.17 branch with mergify
bugfix
labels
Sep 4, 2023
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Sep 4, 2023
Collaborator
LGTM but is it possible to add a test case? |
ShourieG
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Added a triple whitespace to a command line test sample together with an argument, was the only way to add an empty string to test with. |
P1llus
added a commit
that referenced
this pull request
Sep 5, 2023
…e array handling (#36496) (#36504) * [Filebeat][Crowdstrike] Adding fix to ingest pipeline for command line args array handling * changelog PR link update * adding missing semicolon * adding testdata to test the process commandline arg being an empty string (cherry picked from commit 35fe318) Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
…e array handling (elastic#36496) * [Filebeat][Crowdstrike] Adding fix to ingest pipeline for command line args array handling * changelog PR link update * adding missing semicolon * adding testdata to test the process commandline arg being an empty string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Since
Arrays.asList
returns a fixed size array, whileargs
should usually never be an emptry string, on the occasions that it is, it will produce an error becauseremoveIf
tries to modify the array, this PR returns a new ArrayList instead:Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Logs
Error example: