Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][CEL] - Added support for Okta Oauth2 provider #36521

Merged
merged 5 commits into from
Sep 7, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Sep 6, 2023

Type of change

  • Enhancement
  • Docs

Proposed commit message

Added support for Okta as a separate OAuth2 provider. This is required because specific use cases
require access tokens with okta.* scopes, which involves a specific 2 step auth mechanism using a private
RSA JWK to generate a JWT which is in turn used to fetch an access token. Standard client_id & client_secrets don't
work in this scenario. It is a similar implementation to the httpjson PR: #36273. This implementation for CEL ensures feature parity with the httpjson input.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG requested a review from a team as a code owner September 6, 2023 10:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 6, 2023
@ShourieG ShourieG self-assigned this Sep 6, 2023
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 6, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 6, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label 8.11-candidate labels Sep 6, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 6, 2023
@ShourieG ShourieG added the Filebeat Filebeat label Sep 6, 2023
@ShourieG ShourieG added the backport-skip Skip notification from the automated backport with mergify label Sep 6, 2023
@ShourieG ShourieG requested a review from efd6 September 6, 2023 10:55
@ShourieG ShourieG changed the title [filebeat][cel] - Added support for Okta Oauth2 provider [filebeat][CEL] - Added support for Okta Oauth2 provider Sep 6, 2023
@ShourieG ShourieG changed the title [filebeat][CEL] - Added support for Okta Oauth2 provider [Filebeat][CEL] - Added support for Okta Oauth2 provider Sep 6, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-06T10:55:10.743+0000

  • Duration: 82 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 3171
Skipped 176
Total 3347

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ShourieG ShourieG merged commit 06ce3a6 into elastic:main Sep 7, 2023
@ShourieG ShourieG deleted the cel/okta_oauth2 branch September 7, 2023 06:37
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
* added support for okta oauth2

* updated docs

* updated changelog

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify Filebeat Filebeat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Okta oauth2 provider support for CEL
3 participants