[filestream] revert change in symlink resolution #36557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
botelastic
bot
removed
the
needs_team
leehinman
added
needs_team
botelastic
bot
removed
the
needs_team
belimawr
requested changes
Sep 11, 2023
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
Co-authored-by: Tiago Queiroz <contato@tiago.eti.br>
rdner
requested changes
Sep 12, 2023
Co-authored-by: Denis <denis@rdner.de>
rdner
approved these changes
Sep 13, 2023
belimawr
approved these changes
Sep 13, 2023
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* [filestream] revert change in symlink resolution --------- Co-authored-by: Tiago Queiroz <contato@tiago.eti.br> Co-authored-by: Denis <denis@rdner.de> (cherry picked from commit b7d1f80)
mergify bot
pushed a commit
that referenced
this pull request
Sep 13, 2023
* [filestream] revert change in symlink resolution --------- Co-authored-by: Tiago Queiroz <contato@tiago.eti.br> Co-authored-by: Denis <denis@rdner.de> (cherry picked from commit b7d1f80)
This was referenced Sep 13, 2023
Scholar-Li
pushed a commit
to Scholar-Li/beats
that referenced
this pull request
Feb 5, 2024
* [filestream] revert change in symlink resolution --------- Co-authored-by: Tiago Queiroz <contato@tiago.eti.br> Co-authored-by: Denis <denis@rdner.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Revert change introduced in #35734, where if a symbolic link could not be resolved it prevented ingest. Previously this was a debug error, but the file was still ingested.
This restores the original behavior.
This impacts Windows users that mount drives inside of folders.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
On Windows host mount a drive inside a folder and ingest linked files from there.
https://learn.microsoft.com/en-us/windows-server/storage/disk-management/assign-a-mount-point-folder-path-to-a-drive
Related issues
Use cases
Screenshots
Logs