Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat][azure-blob-storage] - Added support for new features and removed partial save mechanism #36690
[filebeat][azure-blob-storage] - Added support for new features and removed partial save mechanism #36690
Changes from 9 commits
cb93f29
4164ba1
09c7252
6488a4c
0e12e55
e69e998
37cc054
2dc4212
79175d4
b08440a
5f53d05
72503ec
448d1c1
2d4a469
6154259
7a3f072
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description doesn't match up with the code I saw. It seems like it filters blobs that are older than the value.
What is the use case for filtering based on a static value? I've seen inputs offer a relative time based filter when user specifies a duration since now like
ignore_older: 168h
orsince: -168h
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have updated the description. The use case here is that some customers in the past specially asked for the ability to filter out based on a specific date time, hence added this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What determines the valid range? I can understand validating that the value is non-negative. But why is there an upper range?
The only reason I can think of for checking the upper value is as a sanity check. It probably does not make sense to configure any value that is in the future.
The bound checking can be added to the struct tag and ucfg will enforce it. Like
validate:"min=1"
for >=1. https://pkg.go.dev/github.com/elastic/go-ucfg#Config.UnpackThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to this being an optional pointer value, struct tags validation causes a nil pointer deference. And yes this is used as a sanity check for permissible timestamp values.
Check failure on line 9 in x-pack/filebeat/input/azureblobstorage/input_stateless.go
GitHub Actions / lint (windows)
Check failure on line 9 in x-pack/filebeat/input/azureblobstorage/input_stateless.go
GitHub Actions / lint (windows)
Check failure on line 9 in x-pack/filebeat/input/azureblobstorage/input_stateless.go
GitHub Actions / lint (linux)
Check failure on line 9 in x-pack/filebeat/input/azureblobstorage/input_stateless.go
GitHub Actions / lint (linux)