Document process.env.whitelist config option #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document `process.env.whitelist` which is used by the Metricbeat system process metricset to specify what environment variables should be captured. Adds documentation for elastic#3337.
andrewkroh
added
docs
needs_backport
ruflin
reviewed
Mar 1, 2017
|
|
||
| This metricset can collect the environment variables that were used to start the | ||
| process. This feature is available on Linux, Darwin, and FreeBSD. By default | ||
| no environment variables are collected. You must configure the environment |
There was a problem hiding this comment.
We could mention here, that for security reasons no env variables are fetched by default.
There was a problem hiding this comment.
I added the reasoning behind the behavior.
monicasarbu
pushed a commit
to monicasarbu/beats
that referenced
this pull request
Mar 4, 2017
* Document process.env.whitelist config option Document `process.env.whitelist` which is used by the Metricbeat system process metricset to specify what environment variables should be captured. Adds documentation for elastic#3337. * Add reason behind default behavior for process env vars (cherry picked from commit f9ac9f2)
monicasarbu
removed
the
needs_backport
ruflin
pushed a commit
that referenced
this pull request
Mar 6, 2017
* Document process.env.whitelist config option Document `process.env.whitelist` which is used by the Metricbeat system process metricset to specify what environment variables should be captured. Adds documentation for #3337. * Add reason behind default behavior for process env vars (cherry picked from commit f9ac9f2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document
process.env.whitelistwhich is used by the Metricbeat system process metricset to specify what environment variables should be captured.Adds documentation for #3337.
Needs back port to 5.3.