Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition for harvester Start / Stop in registry #3780

Closed
wants to merge 1 commit into from

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Mar 21, 2017

There is still a case where a race condition could happen (see TODO). Registry must be improved to also handle this case.

This should not be backported as the issue can only happen on shutdown in very rare cases and should not have any side effect.

Closes #3779

@ruflin ruflin added bug Filebeat Filebeat in progress Pull request is currently in progress. labels Mar 21, 2017
@ruflin ruflin requested a review from 7AC March 21, 2017 09:29
@7AC
Copy link
Contributor

7AC commented Mar 21, 2017

CI is failing with an error I also got in another review so I think it's unrelated to your changes

ERROR: Test that Filebeat works when stdin is closed.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\gopath\src\github.com\elastic\beats\filebeat\tests\system\test_prospector.py", line 139, in test_stdin_eof
    self.wait_until(lambda: self.output_has(lines=2))
  File "C:\gopath\src\github.com\elastic\beats\filebeat\tests\system\../../../libbeat/tests/system\beat\beat.py", line 283, in wait_until
    "Waited {} seconds.".format(max_timeout))
Exception: Timeout waiting for 'cond' to be true. Waited 10 seconds.
======================================================================

@ruflin ruflin force-pushed the fix-harvester-start-race branch from fdae368 to f3efec5 Compare April 20, 2017 08:25
@ruflin
Copy link
Contributor Author

ruflin commented Apr 20, 2017

jenkins, retest it

There is still a case where a race condition could happen (see TODO). Registry must be improved to also handle this case.

This should not be backported as the issue can only happen on shutdown in very rare cases and should not have any side effect.

Closes elastic#3779
@ruflin ruflin force-pushed the fix-harvester-start-race branch from f3efec5 to 8518b4d Compare April 28, 2017 08:32
@ruflin
Copy link
Contributor Author

ruflin commented May 15, 2017

Closing in favor of #4314 Too many things have changed in the meantime.

@ruflin ruflin closed this May 15, 2017
@ruflin ruflin deleted the fix-harvester-start-race branch May 15, 2017 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Filebeat Filebeat in progress Pull request is currently in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants