Make http fields in HAProxy optional to improve compatibility with 1.5 #3788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the http fields do not always exists in HAProxy 1.5. We currently only support 1.6 but as this will not break things, I made the fields optional for better compatibility.
ruflin
added
Metricbeat
|
LGTM, I launched a manual test that passed, is there any quick cheat to test it again for the PR? |
|
jenkins, test it |
|
@exekias ^^- like that |
|
ready to go, can you add a CHANGELOG entry? |
|
@exekias I didn't add a Changelog on purpose as I don't see this as a bug fixes as it is an improvement for a non supported version. If we add a changelog under "Added" I worry that we give the impression that we support 1.5. So I tried to keep this under the radar ;-) |
monicasarbu
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the http fields do not always exists in HAProxy 1.5. We currently only support 1.6 but as this will not break things, I made the fields optional for better compatibility.