-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] ETW input - use errgroup #38009
[Filebeat] ETW input - use errgroup #38009
Conversation
Use errgroup to wait on the ETW consumer routine. Use sync.OnceFunc to wrap the Close() func for the ETW session. Clarify a few log messages.
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💚 Build Succeeded
History
cc @andrewkroh |
💚 Build Succeeded
History
cc @andrewkroh |
💚 Build Succeeded
History
cc @andrewkroh |
💚 Build Succeeded
History
cc @andrewkroh |
💚 Build Succeeded
History
cc @andrewkroh |
💚 Build Succeeded
History
cc @andrewkroh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested
Proposed commit message
Use errgroup to wait on the ETW consumer routine.
Use sync.OnceFunc to wrap the Close() func for the ETW session.
Clarify a few log messages (follow-up to 36915)
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.