Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] ETW input - use errgroup #38009

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Feb 14, 2024

Proposed commit message

Use errgroup to wait on the ETW consumer routine.

Use sync.OnceFunc to wrap the Close() func for the ETW session.

Clarify a few log messages (follow-up to 36915)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Use errgroup to wait on the ETW consumer routine.

Use sync.OnceFunc to wrap the Close() func for the ETW
session.

Clarify a few log messages.
@andrewkroh andrewkroh added enhancement Filebeat Filebeat Team:Security-Windows Platform Windows Platform Team in Security Solution labels Feb 14, 2024
@andrewkroh andrewkroh requested a review from a team as a code owner February 14, 2024 13:38
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 14, 2024
Copy link
Contributor

mergify bot commented Feb 14, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @andrewkroh? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 14, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 141 min 53 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andrewkroh

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @andrewkroh

Copy link
Contributor

@narph narph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested

@andrewkroh andrewkroh merged commit 85e4e46 into elastic:main Feb 21, 2024
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Filebeat Filebeat Team:Security-Windows Platform Windows Platform Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants