x-pack/filebeat/input/httpjson: drop response bodies at end of execution #38116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Filebeat
botelastic
bot
added
needs_team
The response bodies of the first and last responses were being held in a closed-over variable resulting in high static memory loads in some situations. The bodies are not used between periodic executions with the documentation stating that only cursor values are persisted across restarts. The difference in behaviour between using the body field over a restart versus over a sequence of executions in the same run make them unsafe, so clarify the persistence behaviour in the documentation and free the bodies at the end of an execution. A survey of integrations that use the httpjson input did not identify any that are using behaviour that is being removed, but we will need to keep an eye on cases that may have been missed. In general, if persistence is being depended on, the cursor should be being used.
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
💚 Build Succeeded
cc @efd6 |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
andrewkroh
approved these changes
Feb 23, 2024
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
…ion (#38116) The response bodies of the first and last responses were being held in a closed-over variable resulting in high static memory loads in some situations. The bodies are not used between periodic executions with the documentation stating that only cursor values are persisted across restarts. The difference in behaviour between using the body field over a restart versus over a sequence of executions in the same run make them unsafe, so clarify the persistence behaviour in the documentation and free the bodies at the end of an execution. A survey of integrations that use the httpjson input did not identify any that are using behaviour that is being removed, but we will need to keep an eye on cases that may have been missed. In general, if persistence is being depended on, the cursor should be being used. (cherry picked from commit 353dab3)
efd6
added a commit
that referenced
this pull request
Feb 23, 2024
… bodies at end of execution (#38128) * x-pack/filebeat/input/httpjson: drop response bodies at end of execution (#38116) The response bodies of the first and last responses were being held in a closed-over variable resulting in high static memory loads in some situations. The bodies are not used between periodic executions with the documentation stating that only cursor values are persisted across restarts. The difference in behaviour between using the body field over a restart versus over a sequence of executions in the same run make them unsafe, so clarify the persistence behaviour in the documentation and free the bodies at the end of an execution. A survey of integrations that use the httpjson input did not identify any that are using behaviour that is being removed, but we will need to keep an eye on cases that may have been missed. In general, if persistence is being depended on, the cursor should be being used. (cherry picked from commit 353dab3) * remove irrelevant changelog entries --------- Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The response bodies of the first and last responses were being held in a closed-over variable resulting in high static memory loads in some situations. The bodies are not used between periodic executions with the documentation stating that only cursor values are persisted across restarts. The difference in behaviour between using the body field over a restart versus over a sequence of executions in the same run make them unsafe, so clarify the persistence behaviour in the documentation and free the bodies at the end of an execution.
A survey of integrations that use the httpjson input did not identify any that are using behaviour that is being removed, but we will need to keep an eye on cases that may have been missed. In general, if persistence is being depended on, the cursor should be being used.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs