Fix packaging which broke because of asciidocs comments #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version.asciidoc is used during packaging to read out the version number. Recently a comment was introduce in the file which broke the packaging. In before_build.sh the content of the file is copied over and converted to yaml, see https://github.com/elastic/beats/blob/master/dev-tools/packer/xgo-scripts/before_build.sh#L58. As these lines to not seem to be required, I removed them. Alternatively the sed script could be adapted which would be more complex.
|
jenkins, package it |
|
Packaging looks good: http://build-eu-00.elastic.co/job/beats-package-PR/86/ |
|
@dedemorton I'm merging this one to fix the packaging, We can discuss other options if you think it's important to keep that comment in. |
|
@tsg It's fine to remove the comments here. The main thing is having the release-state defined in a central place. :-) |
dedemorton
pushed a commit
to dedemorton/beats
that referenced
this pull request
Mar 30, 2017
The version.asciidoc is used during packaging to read out the version number. Recently a comment was introduce in the file which broke the packaging. In before_build.sh the content of the file is copied over and converted to yaml, see https://github.com/elastic/beats/blob/master/dev-tools/packer/xgo-scripts/before_build.sh#L58. As these lines to not seem to be required, I removed them. Alternatively the sed script could be adapted which would be more complex.
andrewkroh
pushed a commit
that referenced
this pull request
Mar 31, 2017
The version.asciidoc is used during packaging to read out the version number. Recently a comment was introduce in the file which broke the packaging. In before_build.sh the content of the file is copied over and converted to yaml, see https://github.com/elastic/beats/blob/master/dev-tools/packer/xgo-scripts/before_build.sh#L58. As these lines to not seem to be required, I removed them. Alternatively the sed script could be adapted which would be more complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version.asciidoc is used during packaging to read out the version number. Recently a comment was introduce in the file which broke the packaging. In before_build.sh the content of the file is copied over and converted to yaml, see https://github.com/elastic/beats/blob/master/dev-tools/packer/xgo-scripts/before_build.sh#L58. As these lines to not seem to be required, I removed them. Alternatively the sed script could be adapted which would be more complex.