Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs build break from SSL module page #38367

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Fix docs build break from SSL module page #38367

merged 3 commits into from
Mar 18, 2024

Conversation

kilfoyle
Copy link
Contributor

This hopefully will fix several docs build errors due to an unterminated block in metricbeat/docs/modules/mysql.asciidoc

@kilfoyle kilfoyle added Team:Docs Label for the Observability docs team backport-skip Skip notification from the automated backport with mergify labels Mar 18, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Mar 18, 2024
@kilfoyle kilfoyle requested a review from gpop63 March 18, 2024 11:43
@kilfoyle kilfoyle requested a review from rdner March 18, 2024 11:46
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-03-18T12:35:40.466+0000

  • Duration: 51 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 4567
Skipped 905
Total 5472

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@kilfoyle @rdner
Update metricbeat/docs/modules/mysql.asciidoc
fc863b6 
Co-authored-by: Denis <denis@rdner.de>
@rdner rdner mentioned this pull request Mar 18, 2024
Merged
10 tasks
@kilfoyle kilfoyle requested review from a team as code owners March 18, 2024 12:35
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 18, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @kilfoyle

@agithomas
Copy link
Contributor

@gpop63 , can you take a look at this please?

agithomas
agithomas approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @kilfoyle

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @kilfoyle

@kilfoyle kilfoyle merged commit 093ab5e into elastic:main Mar 18, 2024
44 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner left review comments

@agithomas agithomas agithomas approved these changes

@jlind23 jlind23 jlind23 approved these changes

@gpop63 gpop63 Awaiting requested review from gpop63

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@kilfoyle kilfoyle

Labels
backport-skip Skip notification from the automated backport with mergify Team:Docs Label for the Observability docs team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kilfoyle @elasticmachine @agithomas @rdner @jlind23