Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Metricbeat perfmon go:generate commands #3862

Merged
merged 1 commit into from
Mar 31, 2017

Conversation

andrewkroh
Copy link
Member

There were a few issues with the “go generate” commands used in the perfmon metricset.

  • Removed a space from // go:generate. There cannot be spaces.
  • Fixed variable spelling in defs_windows.go. The spelling error was already fixed by hand in the generated files.
  • Update the input file name in one command from pdh.go to pdg_windows.go.
  • Added a wrapper script to ease running commands on Windows, setting GOARCH env var, and redirecting the output to a file.

@andrewkroh
Copy link
Member Author

@maddin2016 Please review this.

@martinscholz83
Copy link
Contributor

Hi @andrewkroh. Thanks for the fixes for the go generate commands. 👍 for the wrapper script!!

There were a few issues with the “go generate” commands used in the perfmon metricset.

- Removed a space from `// go:generate`. There cannot be spaces.
- Fixed variable spelling in defs_windows.go. The spelling error was already fixed by hand in the generated files.
- Update the input file name in one command from pdh.go to pdg_windows.go.
- Added a wrapper script to ease running commands on Windows, setting GOARCH env var, and redirecting the output to a file.
@andrewkroh andrewkroh force-pushed the bugfix/perfmon-go-generate branch from 42e90b3 to aa003fc Compare March 30, 2017 19:17
@andrewkroh
Copy link
Member Author

jenkins, test it

@ruflin ruflin mentioned this pull request Mar 31, 2017
10 tasks
@ruflin ruflin merged commit bc4f4e4 into elastic:master Mar 31, 2017
@monicasarbu monicasarbu deleted the bugfix/perfmon-go-generate branch March 31, 2017 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants