add_cloud_metadata: env var override for providers #38669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Add support for configuring the add_cloud_metadata providers with an environment variable, $BEATS_ADD_CLOUD_METADATA_PROVIDERS. This may be useful when deploying Elastic Agent standalone in a cloud provider managed Kubernetes cluster, where the cloud provider is known at deployment time.
axw
force-pushed
the
add_cloud_metadata_env
branch
from
fa753f5 to
84efc44
Compare
axw
added
the
Team:obs-ds-hosted-services
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
mergify bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
* add_cloud_metadata: env var override for providers Add support for configuring the add_cloud_metadata providers with an environment variable, $BEATS_ADD_CLOUD_METADATA_PROVIDERS. This may be useful when deploying Elastic Agent standalone in a cloud provider managed Kubernetes cluster, where the cloud provider is known at deployment time. * Fix changelog * appease golangci-lint * More appeasement (cherry picked from commit d0399e0)
5 tasks
axw
added a commit
that referenced
this pull request
Apr 16, 2024
…iders (#38965) * add_cloud_metadata: env var override for providers (#38669) * add_cloud_metadata: env var override for providers Add support for configuring the add_cloud_metadata providers with an environment variable, $BEATS_ADD_CLOUD_METADATA_PROVIDERS. This may be useful when deploying Elastic Agent standalone in a cloud provider managed Kubernetes cluster, where the cloud provider is known at deployment time. * Fix changelog * appease golangci-lint * More appeasement (cherry picked from commit d0399e0) * Update CHANGELOG.next.asciidoc --------- Co-authored-by: Andrew Wilkins <axw@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Add support for configuring the add_cloud_metadata providers with an environment variable,
$BEATS_ADD_CLOUD_METADATA_PROVIDERS. This may be useful when deploying Elastic Agent standalone in a cloud provider (e.g. in a managed Kubernetes cluster), where the cloud provider is known at deployment time.This is intended as a workaround for #13816 and issues like it.
Checklist
- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Run Metricbeat enough times on EC2 to trigger #13816, and then check that setting
BEATS_ADD_CLOUD_METADATA_PROVIDERS=ec2disables the openstack provider and the issue no longer occurs.Related issues
Relates to #13816
Use cases
As a user deploying Elastic Agent standalone on EKS, I want to ensure that documents are enriched with EC2 cloud metadata.
Screenshots
N/A
Logs
N/A