x-pack/filebeat/module/o365: fix handling of o365.audit.OperationProperties #38709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Filebeat
botelastic
bot
added
needs_team
…erties In some cases, this field may be a string. This results in a mapping failure. So in cases where the field is a string, conditionally parse out the JSON. Use the ingest pipeline rather than modifying the js processor due to clarity.
💚 Build Succeeded
Expand to view the summary
Build stats
❕ Flaky test reportNo test was executed to be analysed. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
mergify bot
pushed a commit
that referenced
this pull request
Apr 6, 2024
…erties (#38709) In some cases, this field may be a string. This results in a mapping failure. So in cases where the field is a string, conditionally parse out the JSON. Use the ingest pipeline rather than modifying the js processor due to clarity. (cherry picked from commit 8105935) # Conflicts: # x-pack/filebeat/module/o365/fields.go
6 tasks
zeynepyz
pushed a commit
to zeynepyz/beats
that referenced
this pull request
Apr 7, 2024
…erties (elastic#38709) In some cases, this field may be a string. This results in a mapping failure. So in cases where the field is a string, conditionally parse out the JSON. Use the ingest pipeline rather than modifying the js processor due to clarity.
efd6
added a commit
that referenced
this pull request
Apr 8, 2024
…o365.audit.OperationProperties (#38751) * x-pack/filebeat/module/o365: fix handling of o365.audit.OperationProperties (#38709) In some cases, this field may be a string. This results in a mapping failure. So in cases where the field is a string, conditionally parse out the JSON. Use the ingest pipeline rather than modifying the js processor due to clarity. (cherry picked from commit 8105935) # Conflicts: # x-pack/filebeat/module/o365/fields.go * remove irrelevant changelog entries * fix conflict * fix test expectation --------- Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
In some cases, this field may be a string. This results in a mapping failure. So in cases where the field is a string, conditionally parse out the JSON.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs