Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13](backport #38780) [filebeat/netflow]: set event normalisation to true #38802

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 10, 2024

Proposed commit message

This PR enables event normalisation for netflow input and solves this this issue. Specifically the netflow input in 8.13 had a refactor to transition to plugin.V2 and during this it was deemed as safe to disable event normalisation and thus improve the performance. However the produced events contain ip fields that cause similar errors to this following without normalisation enabled

Apr 02 13:57:11 tv filebeat[597]: {"log.level":"warn","@timestamp":"2024-04-02T13:57:11.590Z","log.logger":"elasticsearch","log.origin":{"function":"github.com/elastic/beats/v7/libbeat/outputs/elasticsearch.(*Client).bulkCollectPublishFails","file.name":"elasticsearch/client.go","file.line":454},"message":"Cannot index event (status=400): dropping event! Enable debug logs to view the event and cause.","service.name":"filebeat","ecs.version":"1.6.0"}

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

N/A

How to test this PR locally

Follow the steps in the issue #38703

Related issues

Use cases

Screenshots

N/A

Logs

N/A


This is an automatic backport of pull request #38780 done by Mergify.

* fix(input/netflow): revert event normalisation to true for netflow input

* doc: update CHANGELOG.next.asciidoc

* fix: update fields.asciidoc (unrelated to this work)

* doc: remove irrelevant comment

(cherry picked from commit 2f5ee74)
@mergify mergify bot requested a review from a team as a code owner April 10, 2024 06:15
@mergify mergify bot added the backport label Apr 10, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 10, 2024
@pkoutsovasilis pkoutsovasilis added the Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution label Apr 10, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 10, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 10, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 137 min 47 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pkoutsovasilis pkoutsovasilis merged commit ab555bc into 8.13 Apr 10, 2024
21 checks passed
@pkoutsovasilis pkoutsovasilis deleted the mergify/bp/8.13/pr-38780 branch April 10, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants