[7.17](backport #38814) Dedicated script for detecting changesets on Buildkite #38821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
After the introduction of a centralized beats pipeline and statically defined changeset rules in #38783, we still need a way to grab changes for modules for IT tests. Currently this is done in common.sh#defineModuleFromTheChangeSet(). This commit adds a new script that has only the changeset related functionality, required to build the `MODULE` env var. The functions themselves, are copied from common.sh (with minor enhancements in documentation), paving the way to sunset common.sh in the future. Relates: https://github.com/elastic/ingest-dev/issues/3072 (cherry picked from commit d0dda41)
mergify
bot
requested review from
faec and
leehinman
and removed request for
a team
botelastic
bot
added
the
needs_team
botelastic
bot
removed
the
needs_team
dliappis
requested review from
alexsapran
and removed request for
faec and
leehinman
botelastic
bot
removed
the
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
alexsapran
approved these changes
Apr 10, 2024
michel-laterman
pushed a commit
to michel-laterman/beats
that referenced
this pull request
Apr 17, 2024
elastic#38821) After the introduction of a centralized beats pipeline and statically defined changeset rules in elastic#38783, we still need a way to grab changes for modules for IT tests. Currently this is done in common.sh#defineModuleFromTheChangeSet(). This commit adds a new script that has only the changeset related functionality, required to build the `MODULE` env var. The functions themselves, are copied from common.sh (with minor enhancements in documentation), paving the way to sunset common.sh in the future. Relates: elastic/ingest-dev#3072 (cherry picked from commit d0dda41) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
After the introduction of a centralized beats pipeline and statically
defined changeset rules in #38783, we still need a way to grab
changes for modules for IT tests.
Currently this is done in common.sh#defineModuleFromTheChangeSet().
This commit adds a new script that has only the changeset related
functionality, required to build the
MODULEenv var.The functions themselves, are copied from common.sh (with minor
enhancements in documentation), paving the way to sunset common.sh
in the future.
Related issues
Logs
When changing e.g.
metricbeat/modules/windows/module.yml(see 4165994), invoking the script returns:otherwise, with no changes, returns:
This is an automatic backport of pull request #38814 done by [Mergify](https://mergify.com).