Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved winlogbeat pipeline to central pipeline #38926

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Apr 15, 2024

Proposed commit message

In scope of https://github.com/elastic/ingest-dev/issues/3072 - moved winlogbeatt pipeline triggering to central pipeline
BK Builds: https://buildkite.com/elastic/beats/builds?branch=oakrizan%3Acentralised-pipeline-winlogbeat

Xpack/Heartbeat failure unrelated to current PR, related issue https://github.com/elastic/ingest-dev/issues/3196

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@oakrizan oakrizan added Team:Elastic-Agent Label for the Agent team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify labels Apr 15, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 15, 2024
@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch from 5cca9b4 to da4c0e5 Compare April 15, 2024 09:09
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 15, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 41 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch from da4c0e5 to 386fcdb Compare April 15, 2024 11:11
@oakrizan oakrizan marked this pull request as ready for review April 15, 2024 12:05
@oakrizan oakrizan requested a review from a team as a code owner April 15, 2024 12:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch from 386fcdb to d431b26 Compare April 15, 2024 12:12
Copy link
Contributor

mergify bot commented Apr 16, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b centralised-pipeline-winlogbeat upstream/centralised-pipeline-winlogbeat
git merge upstream/main
git push upstream centralised-pipeline-winlogbeat

@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch 4 times, most recently from 96b6313 to 441b8dc Compare April 17, 2024 12:19
.buildkite/pipeline.yml Outdated Show resolved Hide resolved
.buildkite/scripts/common.sh Outdated Show resolved Hide resolved
.buildkite/winlogbeat/pipeline.winlogbeat.yml Show resolved Hide resolved
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a few comments.

.buildkite/scripts/common.sh Outdated Show resolved Hide resolved
.buildkite/winlogbeat/pipeline.winlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/winlogbeat/pipeline.winlogbeat.yml Show resolved Hide resolved
.buildkite/winlogbeat/pipeline.winlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/winlogbeat/pipeline.winlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/winlogbeat/pipeline.winlogbeat.yml Outdated Show resolved Hide resolved
@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch 2 times, most recently from 7bfaad0 to 6eb0e07 Compare April 17, 2024 19:18
@oakrizan oakrizan requested review from dliappis and pazone April 17, 2024 19:19
@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch from 6eb0e07 to 30bd0b0 Compare April 18, 2024 06:44
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided that extended windows tests also pass (see comment)

.buildkite/winlogbeat/pipeline.winlogbeat.yml Show resolved Hide resolved
@oakrizan oakrizan added the backport-v8.14.0 Automated backport with mergify label Apr 18, 2024
@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch 2 times, most recently from d46db7d to 3bd6b24 Compare April 18, 2024 10:50
@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch from 3bd6b24 to 16dfffa Compare April 18, 2024 13:51
@oakrizan oakrizan added the macOS Enable builds in the CI for darwin testing label Apr 18, 2024
@oakrizan
Copy link
Contributor Author

/test

@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch from 16dfffa to ed7904a Compare April 18, 2024 17:02
@oakrizan
Copy link
Contributor Author

/test

@oakrizan oakrizan force-pushed the centralised-pipeline-winlogbeat branch from ed7904a to f7d1dc7 Compare April 19, 2024 03:32
@oakrizan oakrizan merged commit 2250273 into elastic:main Apr 19, 2024
161 of 163 checks passed
mergify bot pushed a commit that referenced this pull request Apr 19, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)

# Conflicts:
#	.buildkite/winlogbeat/pipeline.winlogbeat.yml
mergify bot pushed a commit that referenced this pull request Apr 19, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)
mergify bot pushed a commit that referenced this pull request Apr 19, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)
oakrizan added a commit that referenced this pull request Apr 19, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)

# Conflicts:
#	.buildkite/winlogbeat/pipeline.winlogbeat.yml
oakrizan added a commit that referenced this pull request Apr 19, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)
oakrizan added a commit that referenced this pull request Apr 19, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)
oakrizan added a commit that referenced this pull request Apr 22, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)
oakrizan added a commit that referenced this pull request Apr 22, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)
oakrizan added a commit that referenced this pull request Apr 22, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)

# Conflicts:
#	.buildkite/winlogbeat/pipeline.winlogbeat.yml
oakrizan added a commit that referenced this pull request Apr 22, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)
oakrizan added a commit that referenced this pull request Apr 22, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request Apr 22, 2024
* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request Apr 22, 2024
…#39068)

* Moved winlogbeat pipeline to central pipeline (#38926)

* updated common.sh

* updated cnetral pipleine with winlogbeat

* fixed typo

(cherry picked from commit 2250273)

# Conflicts:
#	.buildkite/winlogbeat/pipeline.winlogbeat.yml

* resolved conflicts

* moved win-2016 tests to extended group

---------

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
Co-authored-by: Olga Naidjonoka <olga_naidjonoka@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify macOS Enable builds in the CI for darwin testing Team:Elastic-Agent Label for the Agent team :Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants