-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add experimental Kibana module to Metricbeat #3895
Conversation
"version": c.Dict("version", s.Schema{ | ||
"number": c.Str("number"), | ||
}), | ||
"status": c.Dict("status", s.Schema{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsg I wanted to do here state.overall = status.overall.state
but couldn't find a way in schema. Any hints?
c6ee482
to
082e973
Compare
I did a quick compare and contrast between the output of I read the code briefly, but not being an expert I'll just ask: does this support 4.6.4? Unrelated to the above, it wasn't clear to me whether you support custom headers like filebeat does. That's a really important thing for me. |
It looked like I needed to sign in to Kibana in order to hit |
Auth for all metricsets will be added here: #3945 |
The Kibana module is marked experimental as it might change or removed at any time.
082e973
to
5bb43b4
Compare
} | ||
) | ||
|
||
type OverallMetrics struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golint] reported by reviewdog 🐶
exported type OverallMetrics should have comment or be unexported
The Kibana module is marked experimental as it might change or removed at any time.