Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildkite Xpack/Winlogbeat pipeline fixes #39007

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Buildkite Xpack/Winlogbeat pipeline fixes #39007

merged 6 commits into from
Apr 22, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Apr 17, 2024 •
edited
Loading

Proposed commit message

In scope of https://github.com/elastic/ingest-dev/issues/3072 - updated Xpack/Winlogbeat pipeline module test step to use changeset calculation
BK Builds: https://buildkite.com/elastic/beats-xpack-winlogbeat/builds?branch=oakrizan%3Axpack-winlogbeat-fixes

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@oakrizan oakrizan added Team:Elastic-Agent Label for the Agent team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify labels Apr 17, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 17, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 17, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 27 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan oakrizan force-pushed the xpack-winlogbeat-fixes branch 15 times, most recently from f836422 to 8d93055 Compare April 17, 2024 14:18
@oakrizan oakrizan force-pushed the xpack-winlogbeat-fixes branch 2 times, most recently from 277b83a to f60a10b Compare April 18, 2024 08:19
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 18, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b xpack-winlogbeat-fixes upstream/xpack-winlogbeat-fixes
git merge upstream/main
git push upstream xpack-winlogbeat-fixes

@oakrizan oakrizan force-pushed the xpack-winlogbeat-fixes branch from f60a10b to 8c0e294 Compare April 18, 2024 11:08
@oakrizan oakrizan added the backport-v8.14.0 Automated backport with mergify label Apr 18, 2024
@oakrizan oakrizan force-pushed the xpack-winlogbeat-fixes branch from 8c0e294 to 0871809 Compare April 19, 2024 07:20
@oakrizan oakrizan marked this pull request as ready for review April 19, 2024 07:27
@oakrizan oakrizan force-pushed the xpack-winlogbeat-fixes branch from f09dbeb to e460101 Compare April 19, 2024 09:32
@oakrizan oakrizan requested a review from dliappis April 19, 2024 09:34
@oakrizan oakrizan force-pushed the xpack-winlogbeat-fixes branch 2 times, most recently from e586e67 to 18fec0c Compare April 19, 2024 10:22
dliappis
dliappis approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 19, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b xpack-winlogbeat-fixes upstream/xpack-winlogbeat-fixes
git merge upstream/main
git push upstream xpack-winlogbeat-fixes

@oakrizan oakrizan force-pushed the xpack-winlogbeat-fixes branch from 770c276 to d8c4313 Compare April 22, 2024 08:25
@oakrizan oakrizan merged commit 243f9c3 into elastic:main Apr 22, 2024
118 of 136 checks passed
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
@oakrizan @mergify
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
a26c2e5 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
@oakrizan @mergify
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
2a9330a 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)

# Conflicts:
#	.buildkite/scripts/common.sh
#	.buildkite/x-pack/pipeline.xpack.winlogbeat.yml
mergify bot pushed a commit that referenced this pull request Apr 22, 2024
@oakrizan @mergify
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
f133dee 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)

# Conflicts:
#	.buildkite/scripts/common.sh
This was referenced Apr 22, 2024
Merged
Merged
Merged
oakrizan added a commit that referenced this pull request Apr 22, 2024
@oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
fdc2652 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)
oakrizan added a commit that referenced this pull request Apr 22, 2024
@oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
6a06bba 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)
oakrizan added a commit that referenced this pull request Apr 22, 2024
@oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
b1c06b8 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)
oakrizan added a commit that referenced this pull request Apr 22, 2024
@oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
b55a863 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)
oakrizan added a commit that referenced this pull request Apr 22, 2024
@oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
8ffeb13 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)
oakrizan added a commit that referenced this pull request Apr 22, 2024
@oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
e92a22b 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)
oakrizan added a commit that referenced this pull request Apr 22, 2024
@oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007)
e2e1899 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)
oakrizan added a commit that referenced this pull request Apr 22, 2024
@mergify @oakrizan
[7.17](backport #39007) Buildkite Xpack/Winlogbeat pipeline fixes (#3…
1614b93 
…9101)

* Buildkite Xpack/Winlogbeat pipeline fixes (#39007)

* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)

* resolved conflicts

* moved win-2016 step to extended

---------

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
Co-authored-by: Olga Naidjonoka <olga_naidjonoka@epam.com>
oakrizan added a commit that referenced this pull request Apr 22, 2024
@mergify @oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007) (#39102)
c9428eb 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request Apr 22, 2024
@mergify @oakrizan
Buildkite Xpack/Winlogbeat pipeline fixes (#39007) (#39103)
990ef9a 
* updated common.sh

* fixed typo

* updated common.sh

* added changeset ps1 script and updated xpack-winlogbeat pipeline

* pr fixes

* handle backslashes in changeset directories

(cherry picked from commit 243f9c3)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@alexsapran alexsapran Awaiting requested review from alexsapran

@pazone pazone Awaiting requested review from pazone

Assignees

@oakrizan oakrizan

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team :Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oakrizan @elasticmachine @dliappis