Fix panic parsing regular expressions #3907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix parsing regular expression matching patterns for log lines starting with
a date, by taking an optional literal string/character suffix into account
(panic with index out of error, due to expecting a digit-pattern)
- add more test cases for regression
- add support to flatten nested repetitions like `(\d{2}){2}` into `\d{4}`, so
more date-like patterns can be captured. This adds support for capturing
`\d\d\d\d` as simplified `\d{4}` pattern.
(cherry picked from commit 4808f1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a date, by taking an optional literal string/character suffix into account
(panic with index out of error, due to expecting a digit-pattern)
(\d{2}){2}into\d{4}, somore date-like patterns can be captured. This adds support for capturing
\d\d\d\das simplified\d{4}pattern.(cherry picked from commit 4808f1c)