heartbeat: setup default ports in http monitors #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default http to 80 and https to 443 Resolves #3915
|
Could you update the changelog with an entry and potentially also the docs? Should we backport this? |
|
I updated the changelog, I'm not sure the doc deserves an entry for this. About backporting I'm open to suggestions.. |
ruflin
approved these changes
Apr 7, 2017
tsg
added
needs_backport
|
+1 to including this one in 5.4 |
tsg
pushed a commit
that referenced
this pull request
Apr 11, 2017
…tors (#3978) * heartbeat: setup default ports in http monitors Default http to 80 and https to 443 Resolves #3915 (cherry picked from commit c888f3f) * Add entry to changelog (cherry picked from commit aa40255) * Add test Also refactor the code, turns out net.SplitHostPort() doesn't like hosts without ports. (cherry picked from commit bd6898c) * Add newline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default http to 80 and https to 443
Resolves #3915