Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/internal/httplog: improve req/resp logging #39455

Merged
merged 1 commit into from
May 9, 2024
Merged

x-pack/filebeat/input/internal/httplog: improve req/resp logging #39455

merged 1 commit into from
May 9, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 8, 2024 •
edited
Loading

Proposed commit message

Attempt to log the request and response bodies and other details even when copying the body has been reported to have failed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • Backporting because this is a visibility hole in support case.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-v8.12.0 Automated backport with mergify Team:Security-Service Integrations Security Service Integrations Team backport-v8.13.0 Automated backport with mergify labels May 8, 2024
@efd6 efd6 self-assigned this May 8, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 8, 2024
@efd6 efd6 force-pushed the httplog_relaxed branch from deef612 to f200fda Compare May 8, 2024 01:46
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 8, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-08T20:33:21.056+0000

  • Duration: 135 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 3415
Skipped 185
Total 3600

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 marked this pull request as ready for review May 8, 2024 07:15
@efd6 efd6 requested a review from a team as a code owner May 8, 2024 07:15
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 force-pushed the httplog_relaxed branch from f200fda to 1d051bd Compare May 8, 2024 07:58
@efd6
x-pack/filebeat/input/internal/httplog: improve req/resp logging
24e8dd7 
Attempt to log the request and response bodies and other details even
when copying the body has been reported to have failed.
@efd6 efd6 force-pushed the httplog_relaxed branch from 1d051bd to 24e8dd7 Compare May 8, 2024 20:33
@efd6 efd6 merged commit 3efb1e8 into elastic:main May 9, 2024
25 of 30 checks passed
mergify bot pushed a commit that referenced this pull request May 9, 2024
@efd6 @mergify
x-pack/filebeat/input/internal/httplog: improve req/resp logging (#39455
fde0eb7 
)

Attempt to log the request and response bodies and other details even
when copying the body has been reported to have failed.

(cherry picked from commit 3efb1e8)
mergify bot pushed a commit that referenced this pull request May 9, 2024
@efd6 @mergify
x-pack/filebeat/input/internal/httplog: improve req/resp logging (#39455
d6cdf29 
)

Attempt to log the request and response bodies and other details even
when copying the body has been reported to have failed.

(cherry picked from commit 3efb1e8)

# Conflicts:
#	x-pack/filebeat/input/internal/httplog/roundtripper.go
This was referenced May 9, 2024
Closed
Merged
efd6 added a commit that referenced this pull request May 9, 2024
@mergify @efd6
[8.13](backport #39455) x-pack/filebeat/input/internal/httplog: impro…
31cc4b2 
…ve req/resp logging (#39478)

* x-pack/filebeat/input/internal/httplog: improve req/resp logging (#39455)

Attempt to log the request and response bodies and other details even
when copying the body has been reported to have failed.

(cherry picked from commit 3efb1e8)

* remove irrelevant changelog entries
* add pre go1.21 min helper

---------

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels
backport-v8.12.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@efd6 @elasticmachine @andrewkroh @kcreddy