Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing panic on prometheus collector when label has , #3947

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Fixing panic on prometheus collector when label has , #3947

merged 1 commit into from
Apr 7, 2017

Conversation

vjsamuel
Copy link
Contributor

@vjsamuel vjsamuel commented Apr 7, 2017

Fixes #3946

@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

1 similar comment
@elasticmachine
Copy link
Collaborator

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run.

@vjsamuel vjsamuel force-pushed the fix_prometheus_scrape_panic branch 3 times, most recently from 01ea11b to fb37e60 Compare April 7, 2017 04:37
@vjsamuel vjsamuel force-pushed the fix_prometheus_scrape_panic branch from fb37e60 to 1a3e1ed Compare April 7, 2017 04:40
@ruflin
Copy link
Contributor

ruflin commented Apr 7, 2017

jenkins, test it

@ruflin ruflin added Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. review labels Apr 7, 2017
ruflin
ruflin approved these changes Apr 7, 2017
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for green.

@ruflin ruflin merged commit e5dcd4d into elastic:master Apr 7, 2017
@vjsamuel vjsamuel deleted the fix_prometheus_scrape_panic branch April 7, 2017 15:33
@tsg tsg added the v5.4.0 label Apr 12, 2017
tsg pushed a commit to tsg/beats that referenced this pull request Apr 12, 2017
@vjsamuel
Fixing panic on prometheus collector when label has , (elastic#3947)
7b0d21b 
(cherry picked from commit e5dcd4d)
@tsg tsg mentioned this pull request Apr 12, 2017
Merged
@tsg tsg removed the needs_backport PR is waiting to be backported to other branches. label Apr 12, 2017
ruflin pushed a commit that referenced this pull request Apr 12, 2017
@tsg @ruflin
Fixing panic on prometheus collector when label has , (#3947) (#4001)
d5f1cc7 
(cherry picked from commit e5dcd4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vjsamuel @elasticmachine @ruflin @tsg