Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run vet only against local packages #3977

Merged
merged 1 commit into from
Apr 10, 2017
Merged

Run vet only against local packages #3977

merged 1 commit into from
Apr 10, 2017

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Apr 10, 2017

Without this change we are running vet for all packages, including those under vendor folders. I got vet errors for an external dependency I was trying to include

@exekias exekias added :Infra review in progress Pull request is currently in progress. labels Apr 10, 2017
@exekias exekias changed the title Use govendor to run vet only against local packages Run vet only against local packages Apr 10, 2017
@exekias
Copy link
Contributor Author

exekias commented Apr 10, 2017 •
edited
Loading 

$ go list ./...  | grep -v /vendor/ > golist_dump
$ govendor list -no-status +local > govendor_dump
$ diff golist_dump govendor_dump
$

I tested both approaches, I prefer list + grep so I don't need to install govendor, but this is not a strong opinion

@ruflin ruflin merged commit 3054154 into elastic:master Apr 10, 2017
@exekias exekias deleted the vet-local-only branch April 11, 2017 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7AC 7AC 7AC approved these changes

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
in progress Pull request is currently in progress. :Infra review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exekias @ruflin @7AC