x-pack/filebeat/input/entityanalytics/provider/{azuread,okta}: add request tracing support #39821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
Filebeat
botelastic
bot
added
needs_team
efd6
force-pushed
the
s4805-entity_analytics
branch
from
31209b8 to
c1090de
Compare
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
chrisberkhout
approved these changes
Jun 7, 2024
| @@ -383,6 +398,41 @@ func New(cfg *config.C, logger *logp.Logger, auth authenticator.Authenticator) ( | |||
| return &f, nil | |||
| } | |||
|
|
|||
| // requestTrace decorates cli with an httplog.LoggingRoundTripper if cfg.Trace | |||
There was a problem hiding this comment.
Suggested change
| // requestTrace decorates cli with an httplog.LoggingRoundTripper if cfg.Trace | |
| // requestTrace decorates cli with an httplog.LoggingRoundTripper if cfg.Tracer |
| ) | ||
| traceLogger := zap.New(core) | ||
|
|
||
| const margin = 1e3 // 1OkB ought to be enough room for all the remainder of the trace details. |
6 tasks
Merged
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Run tests in the okta/internal/okta and azuread/fetcher/graph packages with the
-request_traceflag to see tracing behaviour.Related issues
Use cases
Screenshots
Logs