Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagetypeinfo behavior #39985

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Jun 20, 2024

Proposed commit message

closes #32026

So, the linux kernel will truncate page counts over 100k:
https://github.com/torvalds/linux/blob/e5b3efbe1ab1793bb49ae07d56d0973267e65112/mm/vmstat.c#L1521-L1528

We weren't handling this previously, so the metricset would just error out on the string >100000, as it didn't match the provided regex.

This fixes that, and also adds a log line and bit of documentation to clarify how it works.

As the attached issue notes, this is a bit of a hard problem to solve "properly" as attempting to get creative and supplement data from /proc/buddyinfo instead will almost certainly result in misaligned data.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 20, 2024
@fearful-symmetry fearful-symmetry self-assigned this Jun 20, 2024
@fearful-symmetry fearful-symmetry requested a review from a team as a code owner June 20, 2024 18:05
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 20, 2024
Copy link
Contributor

mergify bot commented Jun 20, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @fearful-symmetry? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jun 20, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b pagetypeinfo-fixes upstream/pagetypeinfo-fixes
git merge upstream/main
git push upstream pagetypeinfo-fixes

@pierrehilbert pierrehilbert merged commit a8704b4 into elastic:main Jun 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error fetching data for metricset linux.pageinfo: error reading pagetypeinfo
4 participants