Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x-pack/filebeat/input/http_endpoint: add ability to remove request trace logs #40005

Merged
merged 1 commit into from
Jun 28, 2024
Merged

x-pack/filebeat/input/http_endpoint: add ability to remove request trace logs #40005

merged 1 commit into from
Jun 28, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 25, 2024

Proposed commit message

This is essentially a replay of #39969, but for the http_endpoint input.

The previous configuration system did not allow users to remove trace logs from agents after they are no longer needed. This is potential security risk as it leaves potentially sensitive information on the file system beyond its required lifetime. The mechanism for communicating to the input whether to write logs is not currently powerful enough to indicate that existing logs should be removed without deleting logs from other instances. So add an enabled configuration option to allow the target name to be sent independently of whether the files should be written or removed.

The new option is optional, defaulting to the previous behaviour so that it can be opted into via progressive repair in the client integrations.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify Team:Security-Service Integrations Security Service Integrations Team labels Jun 25, 2024
@efd6 efd6 self-assigned this Jun 25, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 25, 2024
@efd6 efd6 force-pushed the 39969-http_endpoint branch from 6a5b42c to 32af35c Compare June 25, 2024 01:15
@efd6 efd6 marked this pull request as ready for review June 25, 2024 03:11
@efd6 efd6 requested a review from a team as a code owner June 25, 2024 03:11
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 25, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 39969-http_endpoint upstream/39969-http_endpoint
git merge upstream/main
git push upstream 39969-http_endpoint

@efd6 efd6 force-pushed the 39969-http_endpoint branch from 32af35c to 92c9359 Compare June 25, 2024 21:39
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 27, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 39969-http_endpoint upstream/39969-http_endpoint
git merge upstream/main
git push upstream 39969-http_endpoint

@efd6 efd6 force-pushed the 39969-http_endpoint branch from 92c9359 to c6305d0 Compare June 27, 2024 20:53
@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 28, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 39969-http_endpoint upstream/39969-http_endpoint
git merge upstream/main
git push upstream 39969-http_endpoint

@efd6
x-pack/filebeat/input/http_endpoint: add ability to remove request tr…
9946aa2 
…ace logs

This is essentially a replay of elastic#39969, but for the http_endpoint input.

The previous configuration system did not allow users to remove trace
logs from agents after they are no longer needed. This is potential
security risk as it leaves potentially sensitive information on the file
system beyond its required lifetime. The mechanism for communicating to
the input whether to write logs is not currently powerful enough to
indicate that existing logs should be removed without deleting logs from
other instances. So add an enabled configuration option to allow the
target name to be sent independently of whether the files should be
written or removed.

The new option is optional, defaulting to the previous behaviour so
that it can be opted into via progressive repair in the client
integrations.
@efd6 efd6 force-pushed the 39969-http_endpoint branch from c6305d0 to 9946aa2 Compare June 28, 2024 03:12
@efd6 efd6 merged commit 5caa070 into elastic:main Jun 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemamartinez chemamartinez chemamartinez approved these changes

Assignees

@efd6 efd6

Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@efd6 @elasticmachine @chemamartinez