Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x-pack/filebeat/input/entityanalytics/provider/internal/activedirectory: relax base DN constraint #40054

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jun 28, 2024

Proposed commit message

Apparently the base DN prefixes used in the wild are not restricted to CN=Users, so remove that check in the query.


See https://discuss.elastic.co/t/ad-entity-analytics-invalid-base-dn/362071 for background.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added enhancement Filebeat Filebeat backport-skip Skip notification from the automated backport with mergify Team:Security-Service Integrations Security Service Integrations Team labels Jun 28, 2024
@efd6 efd6 self-assigned this Jun 28, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 28, 2024
@efd6 efd6 marked this pull request as ready for review June 28, 2024 09:54
@efd6 efd6 requested a review from a team as a code owner June 28, 2024 09:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

mergify bot commented Jun 28, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ad_relax upstream/ad_relax
git merge upstream/main
git push upstream ad_relax

Copy link
Contributor

mergify bot commented Jun 28, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ad_relax upstream/ad_relax
git merge upstream/main
git push upstream ad_relax

…ry: relax base DN constraint

Apparently the base DN prefixes used in the wild are not restricted to
CN=Users, so remove that check in the query.
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit 77d71d5 into elastic:main Jul 1, 2024
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants