-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aws] Fix missing metrics bug when include_linked_accounts set to false #40135
[aws] Fix missing metrics bug when include_linked_accounts set to false #40135
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed commit message
This PR is to fix a bug in cloudwatch metricbeat module when include_linked_accounts is false. Because where the wrongly put return, we are missing metrics in pagination. I also added a test for the case when there is more than one page of results from ListMetrics API.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
No disruptive user impact.
How to test this PR locally
aws.yml
looks like this:You should see metrics only being collected from 2 RDS clusters. But if you change the
include_linked_accounts
totrue
, then you will get metrics from all clusters (5 in this case).3. Apply the changes from this PR and rebuild metricbeat locally. Run with the same
aws.yml
withinclude_linked_accounts
equals tofalse
and you should see metrics from all clusters now.Related issues