x-pack/filebeat/input/{cel,salesforce}: check response for nilness before logging #40144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Filebeat
botelastic
bot
added
needs_team
…fore logging It turns out that retryablehttp will pass a nil *http.Response to the client's ErrorHandler function although this is not documented. In the cases where we are using this, this will result in a nil deference panic when the retries exceed their maximum. So, check for nilness to avoid this.
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
shmsr
approved these changes
Jul 9, 2024
mergify bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
…fore logging (#40144) It turns out that retryablehttp will pass a nil *http.Response to the client's ErrorHandler function although this is not documented. In the cases where we are using this, this will result in a nil deference panic when the retries exceed their maximum. So, check for nilness to avoid this. (cherry picked from commit b056515)
6 tasks
andrewkroh
pushed a commit
that referenced
this pull request
Jul 23, 2024
…fore logging (#40144) (#40159) It turns out that retryablehttp will pass a nil *http.Response to the client's ErrorHandler function although this is not documented. In the cases where we are using this, this will result in a nil deference panic when the retries exceed their maximum. So, check for nilness to avoid this. (cherry picked from commit b056515) Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
It turns out that retryablehttp will pass a nil *http.Response to the client's ErrorHandler function although this is not documented. In the cases where we are using this, this will result in a nil deference panic when the retries exceed their maximum. So, check for nilness to avoid this.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs