New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.15](backport #40121) [filebeat][filestream] Enable status reporter for filestream input #40168

Closed

mergify wants to merge 4 commits into 8.15 from mergify/bp/8.15/pr-40121

Contributor

mergify bot commented Jul 10, 2024 •

edited by zube bot

Loading

Proposed commit message

Enable StatusReporter for filestream input which was introduced in #39209

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Closes 39734

Use cases

This PR allows the filestream to report its status to elastic-agent. This would keep the status of the unit up-to-date and would help with diagnostics.

Screenshots

Logs

This is an automatic backport of pull request #40121 done by [Mergify](https://mergify.com).


          [filebeat][filestream] Enable status reporter for filestream input (#…

0e73241

…40121)

* initial commit filestream status

* fix: test cleanup

* fix: move the statusReporter to correct place

* fix: remove test cases for now

* chore: add changelog

* fix: address review comments

(cherry picked from commit 0e9c9de)

mergify bot added the backport label

mergify bot requested a review from a team as a code owner

July 10, 2024 14:14

mergify bot requested review from fearful-symmetry and removed request for a team

July 10, 2024 14:14

mergify bot assigned VihasMakwana

mergify bot requested a review from faec

July 10, 2024 14:14

botelastic bot added the needs_team label

pierrehilbert added the Team:Elastic-Agent-Data-Plane label

Collaborator

elasticmachine commented Jul 10, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

botelastic bot removed the needs_team label

pierrehilbert requested review from cmacknz and VihasMakwana and removed request for fearful-symmetry and faec

July 10, 2024 16:05

VihasMakwana approved these changes

View reviewed changes

Collaborator

jlind23 commented Jul 10, 2024

@pierrehilbert 8.15 Ff has started a week ago, I really don't think we should backport this now.
Any thoughts?

Collaborator

pierrehilbert commented Jul 11, 2024

We discussed this yesterday with @cmacknz and he mentioned he will check how risky it is.
One known issue is that we will now let users be aware that something is not working correctly with their inputs and therefore our support teams will probably get some tickets about it.

Contributor

belimawr commented Jul 11, 2024

The original PR made one of our integration tests to start failing on main, so if this backport PR is merged to 8.15, then the following fix PR also needs to be merged: #40195.

Ideally the fix should be merged first (it does not depend o the code from this PR), so we won't break CI builds on 8.15.

Contributor Author

mergify bot commented Jul 15, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

Contributor Author

mergify bot commented Jul 22, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.15/pr-40121 upstream/mergify/bp/8.15/pr-40121
git merge upstream/8.15
git push upstream mergify/bp/8.15/pr-40121

Contributor Author

mergify bot commented Jul 22, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏


          Merge branch '8.15' into mergify/bp/8.15/pr-40121

35bc195

Collaborator

pierrehilbert commented Jul 22, 2024

Shouldn't be merged before 8.15.1

Contributor Author

mergify bot commented Jul 29, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

1 similar comment

Contributor Author

mergify bot commented Aug 5, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

Contributor Author

mergify bot commented Aug 8, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.15/pr-40121 upstream/mergify/bp/8.15/pr-40121
git merge upstream/8.15
git push upstream mergify/bp/8.15/pr-40121


          Merge branch '8.15' into mergify/bp/8.15/pr-40121

b001e5e

Contributor Author

mergify bot commented Aug 12, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏


          Merge branch '8.15' into mergify/bp/8.15/pr-40121

0712dda

Contributor Author

mergify bot commented Aug 19, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

2 similar comments

Contributor Author

mergify bot commented Aug 26, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

Contributor Author

mergify bot commented Sep 2, 2024

This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏

cmacknz closed this

Member

cmacknz commented Sep 4, 2024

Let's wait for 8.16

mergify bot deleted the mergify/bp/8.15/pr-40121 branch

September 4, 2024 13:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Elastic-Agent-Data-Plane