-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change SQS metrics statistic method #40207
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* Change SQS metrics statistic method * add doc change and changelog (cherry picked from commit 918edab) # Conflicts: # x-pack/metricbeat/module/aws/fields.go
* Change SQS metrics statistic method * add doc change and changelog (cherry picked from commit 918edab)
* Change SQS metrics statistic method * add doc change and changelog (cherry picked from commit 918edab)
Proposed commit message
This PR is to fix statistic method applied to diff metrics in SQS metricset from aws module. This change has been done in elastic/integrations#8521 but didn't make it in Beats.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
It will not, because rename processor renamed all the fields from sqs metricset already. Users need to pay attention to the documentation change on the field description. But dashboards will not be broken.