Properly shut down crawler in case one prospector is misconfigured #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
Filebeat
|
This needs backport to 5.3 and 5.4 |
| @@ -32,6 +32,10 @@ func NewLog(p *Prospector) (*Log, error) { | |||
| config: p.config, | |||
| } | |||
|
|
|||
| if len(p.config.Paths) == 0 { | |||
| return nil, fmt.Errorf("Each prospector must have at least one path defined.") | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
error strings should not be capitalized or end with punctuation or a newline
|
LGTM, can you address reviewdog comment and add a changelog? |
If one prospector started to already send data and a second one was misconfigured, the beat paniced during shutdown. This is no prevented by properly shutting down the crawler also on error. Closes elastic#3917
|
@exekias Updated |
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Apr 19, 2017
…lastic#4037) If one prospector started to already send data and a second one was misconfigured, the beat paniced during shutdown. This is no prevented by properly shutting down the crawler also on error. Closes elastic#3917 (cherry picked from commit 95195cc)
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Apr 19, 2017
…lastic#4037) If one prospector started to already send data and a second one was misconfigured, the beat paniced during shutdown. This is no prevented by properly shutting down the crawler also on error. Closes elastic#3917 (cherry picked from commit 95195cc)
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Apr 19, 2017
…lastic#4037) If one prospector started to already send data and a second one was misconfigured, the beat paniced during shutdown. This is no prevented by properly shutting down the crawler also on error. Closes elastic#3917 (cherry picked from commit 95195cc)
ruflin
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one prospector started to already send data and a second one was misconfigured, the beat paniced during shutdown. This is no prevented by properly shutting down the crawler also on error.
Closes #3917