Adding support for include_labels and include_annotations in kubernetes processor #4043
Conversation
vjsamuel
force-pushed
the
kubernetes_include_labels
branch
from
f1a5216
to
8944e98
Compare
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
1 similar comment
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run. |
vjsamuel
force-pushed
the
kubernetes_include_labels
branch
from
8944e98
to
5392c69
Compare
| return meta | ||
| } | ||
|
|
||
| type GenFilteredMeta struct { |
There was a problem hiding this comment.
I'm wondering, why do you need 2 different metadata generators? All the filtering logic could go into the default, isn't it?
There was a problem hiding this comment.
just makes the default one slightly faster with lesser checks ;)
| //Load default indexer configs | ||
| if config.DefaultIndexers.Enabled == true { | ||
| for key, cfg := range Indexing.defaultIndexerConfigs { | ||
| config.Indexers = append(config.Indexers, map[string]common.Config{key: cfg}) |
There was a problem hiding this comment.
would this need the rwmutex part? processor init is anyway something that is serial
There was a problem hiding this comment.
that's as of today, some day we may add changes like processors reloading that could mess with concurrency. I prefer just to trust the functions are thread safe as other modules are calling them
| //Load default matcher configs | ||
| if config.DefaultMatchers.Enabled == true { | ||
| for key, cfg := range Indexing.defaultMatcherConfigs { | ||
| config.Matchers = append(config.Matchers, map[string]common.Config{key: cfg}) |
vjsamuel
force-pushed
the
kubernetes_include_labels
branch
from
5392c69
to
71dfae1
Compare
include_labels: ["foo"]would make sure that only foo is part of the "labels" map in the kubernetes metadata.if user wishes to add select annotations then it can be done using
include_annotations: ["xyz"]